-
Notifications
You must be signed in to change notification settings - Fork 10
Add Virus collect feature #386
Add Virus collect feature #386
Conversation
0ea9745
to
66ce129
Compare
2e63df1
to
53dac79
Compare
53dac79
to
f3be608
Compare
f3be608
to
640f243
Compare
640f243
to
efab5d4
Compare
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/386. |
Reviewed 55 of 55 files at r1. lib/network/henforcer/bounce.ex, line 113 at r1 (raw file):
Review lib/software/action/virus.ex, line 34 at r1 (raw file):
Add this into the lib/software/internal/virus.ex, line 134 at r1 (raw file):
Review lib/software/model/virus.ex, line 104 at r1 (raw file):
doc + spec lib/software/model/virus.ex, line 107 at r1 (raw file):
Add issue about global Balance module and reference it lib/software/process/virus/collect.ex, line 125 at r1 (raw file):
doc lib/software/websocket/requests/virus/collect.ex, line 20 at r1 (raw file):
doc lib/software/websocket/requests/virus/collect.ex, line 42 at r1 (raw file):
Use backquotes lib/software/websocket/requests/virus/collect.ex, line 138 at r1 (raw file):
spec lib/software/websocket/requests/virus/collect.ex, line 145 at r1 (raw file):
spec test/support/software/setup/virus.ex, line 33 at r1 (raw file):
doc the extra conditional test/universe/bank/henforcer/bank_test.exs, line 25 at r1 (raw file):
extra line Comments from Reviewable |
Reviewed 10 of 10 files at r2. Comments from Reviewable |
when will we next hear about an update for he2? |
This PR is meant to allow players to collect money off of active viruses and have the earnings transferred to their bank account / bitcoin wallet.
collect/2
on VirusActionVirusHenforcer
Incidental
src_atm_id
,src_acc_number
,tgt_atm_id
andtgt_acc_number
were added to the Process structBankHenforcer
andowns_bank_account?
check onEntityHenforcer
BankAccountUpdatedEvent
(part of Add Bank-related requests/events #361)BankAction.direct_deposit/2
order
macro onHELL.Ecto.Macros
This change is